tests: fix compiler warning if tracing is disabled#5311
Merged
ethomson merged 1 commit intolibgit2:masterfrom Nov 28, 2019
Merged
tests: fix compiler warning if tracing is disabled#5311ethomson merged 1 commit intolibgit2:masterfrom
ethomson merged 1 commit intolibgit2:masterfrom
Conversation
Member
Author
|
/cc @ethomson |
f846700 to
3feda6a
Compare
If building libgit2's test suite with tracing disabled, then the compiler will emit a warning due to the unused `message_prefix` function. Fix the issue by wrapping the whole file into ifdef's for `GIT_TRACE` and providing separate empty function implementations for both `cl_global_trace_register` and `cl_global_trace_disable`.
3feda6a to
1d470a7
Compare
tiennou
approved these changes
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If building libgit2's test suite with tracing disabled, then the
compiler will emit a warning due to the unused
message_prefixfunction. Fix the issue by wrapping the whole file into ifdef's for
GIT_TRACEand providing separate empty function implementations forboth
cl_global_trace_registerandcl_global_trace_disable.