Add optional codeSelection property and refactor feedback comment#299005
Open
Add optional codeSelection property and refactor feedback comment#299005
Conversation
…nt feedback variable entries
…k comment renderer
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for carrying an optional code snippet alongside agent feedback attachment items, and refactors the Sessions “agent feedback” hover to render that snippet directly instead of trying to synchronously read editor models.
Changes:
- Extend
IAgentFeedbackVariableEntry.feedbackItems[]with an optionalcodeSelection?: string. - Refactor
AgentFeedbackHoverto usecodeSelectionfor the hover code block and remove dependency onIModelService. - Populate
codeSelectionfrom the attachment contribution’s snippet cache when constructing the attachment entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/attachments/chatVariableEntries.ts | Adds optional codeSelection to agent feedback attachment item shape. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackHover.ts | Uses codeSelection to render snippet in hover; removes model/range dependency. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackAttachment.ts | Passes cached snippet into feedbackItems[].codeSelection when building attachment entry. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackAttachment.ts
Show resolved
Hide resolved
bpasero
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.