Skip to content

modal - focus editor on title click#299038

Merged
bpasero merged 2 commits intomainfrom
ben/brainy-bear
Mar 4, 2026
Merged

modal - focus editor on title click#299038
bpasero merged 2 commits intomainfrom
ben/brainy-bear

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Mar 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 19:25
@bpasero bpasero self-assigned this Mar 3, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the modal editor part’s focus behavior so focus is moved into the active editor group (instead of the dialog container), and attempts to refocus the active editor when clicking the modal title/header area.

Changes:

  • Remove tabIndex from the modal dialog container and stop focusing the container directly.
  • Focus the modal’s active editor group on open.
  • Add a header click handler intended to focus the active editor.

@bpasero bpasero merged commit 1f4b2e1 into main Mar 4, 2026
20 checks passed
@bpasero bpasero deleted the ben/brainy-bear branch March 4, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants