sessions - fix close action showing up in modal editors when tabbed#299041
Merged
sessions - fix close action showing up in modal editors when tabbed#299041
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Sessions window defaults to prevent editor tab/close UI from appearing unexpectedly in modal editor overlays by no longer overriding the global tab-visibility setting.
Changes:
- Removes the Sessions defaults override for
workbench.editor.showTabs. - Minor formatting-only whitespace adjustment in
EditorTitleControl.updateOptions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/editor/editorTitleControl.ts | Formatting-only change (blank line) in updateOptions. |
| src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts | Removes Sessions default override for workbench.editor.showTabs. |
Yoyokrazy
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.