Skip to content

Make Commit.create async #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
May 4, 2016
Merged

Make Commit.create async #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c21ef5
Make `Commit.create` async
May 3, 2016
a734b9f
Fix filemode changes test
May 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,17 +416,21 @@
"update_ref": {
"isOptional": true
}
},
"isAsync": true,
"return": {
"isErrorCode": true
}
},
"git_commit_create_buffer": {
"ignore": true
},
"git_commit_create_from_callback": {
"ignore": true
},
"git_commit_create_from_ids": {
"ignore": true
},
"git_commit_create_from_v": {
"ignore": true
},
"git_commit_extract_signature": {
"ignore": true
},
Expand Down
16 changes: 10 additions & 6 deletions test/tests/stage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,19 @@ describe("Stage", function() {
return index.writeTree();
})
.then(function (oid) {
var signature = NodeGit.Signature.create("Foo bar",
"foo@bar.com", 123456789, 60);
return test.repository.createCommit("HEAD", signature, signature,
"initial commit", oid, []);
return test.repository.getHeadCommit()
.then(function(parent) {
var signature = NodeGit.Signature.create("Foo bar",
"foo@bar.com", 123456789, 60);
return test.repository.createCommit("HEAD", signature, signature,
"initial commit", oid, [parent]);
});
//... alright, we did a commit.
})
//Now if we compare head commit to index, should be a filemode change
// Now if we compare head commit to the workdir,
// there shouldn't be a filemode change
.then(function() {
return compareFilemodes(false, index, 0111 /* expect +x */);
return compareFilemodes(true, null, 0);
});
});

Expand Down