Merged
Conversation
There was a linking exception that was fixed by changing the order of includes for node and v8 headers
johnhaley81
added a commit
that referenced
this pull request
Feb 24, 2016
Fix debug build on windows
| @@ -1,7 +1,7 @@ | |||
| // This is a generated file, modify: generate/templates/nodegit.cc. | |||
?
Collaborator
Author
There was a problem hiding this comment.
That's there in case somebody is looking at the generated file src/nodegit.cc and is like "why can't I commit my changes.
Member
There was a problem hiding this comment.
Should we add a Combyne comment above it?
{%-- JavaScript comment below alerts contributors to not edit the generated source --%}
Collaborator
There was a problem hiding this comment.
Probably. That would at least clarify a bit. Might be nicer though if we just do that when we get the compiled output back, like
// This is a generated file, modify: {root template}. in the generateNativeCode.js
Looks like it's around lines 117/120 (probably a few others too)
Collaborator
|
Yeah, i wish we had a good way to point to the root template in combyne so we didnt have to include that in the not generated files. |
Collaborator
Collaborator
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a linking exception that was fixed by changing the order of includes for node and v8 headers