labels: stricter version match in base branch#70
Conversation
Minor adjustment to the regex matching the base branch a PR is targeted against. Refs nodejs#55 (comment)
|
I'm +0/leaning more towards -1 on this. What situation could arise where the current regexp would not match correctly? If anything I could see other version-specific branch suffixes, which would mean more work in maintaining the regexp. shrug |
|
I would prefer this, since it's possible that otherwise it may match branches that are say, more specific and may create new labels unwarrented. (thinking release proposals, etc) |
|
Release proposals have either been starting with |
|
Although not too opinionated about this, in the case of having more explicit code, I'm leaning towards +1 on merging this. Regex isn't everyones favorite lunch, adding the |
|
As far as I see, in sum the votes leaned slightly towards merging this, so here it goes to close this stalled PR. |


Minor adjustment to the regex matching the base branch a PR is targeted against.
Refs #55 (comment)
/cc @Fishrock123