test: check and fail inspector-cluster-port-clash#14074
Closed
danbev wants to merge 2 commits intonodejs:masterfrom
Closed
test: check and fail inspector-cluster-port-clash#14074danbev wants to merge 2 commits intonodejs:masterfrom
danbev wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
|
Because this is a |
Contributor
|
FWIW alternatively you could simply add |
Contributor
|
As for this PR's change, it's a bit too generic. If you want to pursue such a change, I'd rather have a special flag in the test (something like |
Contributor
Author
Ah great, that would be much simpler. Thanks, I'll update the PR. |
Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped.
c28f46e to
2d0d934
Compare
Contributor
Author
cjihrig
approved these changes
Jul 5, 2017
| if (process.config.variables.v8_enable_inspector === 0) { | ||
| // When the V8 inspector is disabled, using either --without-inspector or | ||
| // --without-ssl, this test will not fail which it is expected to do. | ||
| // The following fail will allow this test to be skipped by failing it. |
Contributor
There was a problem hiding this comment.
Could you add something to this comment about replacing this block with common.skipIfInspectorDisabled() when/if this test is moved out of known_issues.
Contributor
Author
There was a problem hiding this comment.
Good idea, I'll add a comment about that.
refack
approved these changes
Jul 6, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Jul 6, 2017
Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped. PR-URL: nodejs#14074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
Author
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped. PR-URL: #14074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped. PR-URL: #14074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped. PR-URL: #14074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this test fail when configured --without-inspector or
--without-ssl as it is expected to fail but the skipIfInspectorDisabled
check will exit as if the test was successful.
This commit checks if inspector support is available and fails the test
allowing the test to be skipped.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tools