async_hooks: consistent internal naming#15569
Closed
AndreasMadsen wants to merge 2 commits intonodejs:masterfrom
AndreasMadsen:async-hooks-internal-rename
Closed
async_hooks: consistent internal naming#15569AndreasMadsen wants to merge 2 commits intonodejs:masterfrom AndreasMadsen:async-hooks-internal-rename
AndreasMadsen wants to merge 2 commits intonodejs:masterfrom
AndreasMadsen:async-hooks-internal-rename
Conversation
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/10219/ /cc @nodejs/async_hooks |
refack
approved these changes
Sep 23, 2017
addaleax
approved these changes
Sep 23, 2017
Member
Author
BridgeAR
approved these changes
Sep 24, 2017
Member
Author
|
Because of the potential for merge conflicts, I will merge this as soon as 72 hours have passed. If anyone have objections, now is the time to say so. |
Member
Author
jasnell
approved these changes
Sep 25, 2017
Member
|
Partial re-run of CI: https://ci.nodejs.org/job/node-test-commit-plinux/11672/ |
Member
Author
|
@jasnell Thanks, but it failed again. I think the CI is having some tough days. New partial CI: https://ci.nodejs.org/job/node-test-commit-plinux/11686/ |
Member
Author
|
Landed in 3a69ef5 |
AndreasMadsen
added a commit
that referenced
this pull request
Sep 26, 2017
PR-URL: #15569 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2017
PR-URL: #15569 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2017
PR-URL: #15569 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
Original-PR-URL: nodejs/node#15569 Original-Reviewed-By: Refael Ackermann <refack@gmail.com> Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Original-Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
PR-URL: ayojs#87 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Original-PR-URL: nodejs/node#15569 Original-Reviewed-By: Refael Ackermann <refack@gmail.com> Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
PR-URL: #15569 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Opted for dont-land. LMK if you want to do a larger effort at backporting the current async_hooks implementation to v6.x |
Member
Author
|
I'm always forgetting those don't land labels :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our internal naming and API doesn't match the external API. This fixes that.
Note: we actually have a bit of external API with the old naming scheme,
promiseHandle.parentId,newUidandinitTriggerId. I didn't touch those, as I wanted to just focus on the internal naming.refack: moved description to top
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks