benchmark: chunky http client benchmark variation and server#228
Closed
rudi-cilibrasi wants to merge 3 commits intonodejs:v1.xfrom
rudi-cilibrasi:benchmark-chunky-http
Closed
benchmark: chunky http client benchmark variation and server#228rudi-cilibrasi wants to merge 3 commits intonodejs:v1.xfrom rudi-cilibrasi:benchmark-chunky-http
rudi-cilibrasi wants to merge 3 commits intonodejs:v1.xfrom
rudi-cilibrasi:benchmark-chunky-http
Conversation
benchmark/net/chunky_http_client.js
Outdated
Member
There was a problem hiding this comment.
Style: please indent with two spaces here.
Author
|
Thanks for the great comments Ben they are all done! |
Contributor
There was a problem hiding this comment.
This could throw with Error: ENOENT. Instead do:
try {
fs.unlinkSync(PIPE);
} catch (e) { }
benchmark/net/chunky_http_client.js
Outdated
Member
There was a problem hiding this comment.
Style: the convention is to use single quotes. There is usually a blank line after 'use strict'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.