Conversation
|
Wait, it didn't fail on linuxone? Let me start a full CI... |
It's a liker issue, so it could arise from several reasons; (1) old compiled artifacts (2) C++ template mismatch (3) |
|
I think we can exclude (1). I can reproduce after a |
|
macOS: I fixed that issue on Linux with d46ee3e#diff-30246878345a874b2105006560a03f27R2530 |
|
Errors on Windows: Details |
This comment has been minimized.
This comment has been minimized.
|
plinux i.e. gcc-6 on ubuntu1404 over PPC64-LE: |
|
Well, there a bit of more gyp refactoring needed to mirror the changes in |
|
node/tools/icu/icu_versions.json Line 2 in 1a54d0f |
|
@targos did we not plan to land 7.5 in v12? Or are we going to open a special backport later that contains commits to make it ABI compatible? |
|
@BridgeAR The latter. Let's make it work without changes first. |
srl295
left a comment
There was a problem hiding this comment.
please delete obsolete ICU patches
ryzokuken
left a comment
There was a problem hiding this comment.
Builds and tests pass w/ refack@6720bd3
Xcode 10.2.1
Build version 10E1001
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.5.0
Thread model: posix
This comment has been minimized.
This comment has been minimized.
V8 7.5 is now doing it natively (both BOM and shebang, and proper combinations of), so our code was doing unnecessary work, and it's tests were failing (mostly the ones who expected failures). Refs: |
|
OK. Thanks for the info. |

Help wanted to fix remaining failures!
See #27375 (comment)