process: disallow some uses of Object.defineProperty() on process.env#28006
Merged
nodejs-github-bot merged 4 commits intonodejs:masterfrom Apr 4, 2022
Merged
process: disallow some uses of Object.defineProperty() on process.env#28006nodejs-github-bot merged 4 commits intonodejs:masterfrom
nodejs-github-bot merged 4 commits intonodejs:masterfrom
Conversation
addaleax
reviewed
Jun 1, 2019
Member
addaleax
left a comment
There was a problem hiding this comment.
I’m labelling this semver-major because it adds a throw, but I don’t have a strong opinion on that and we can remove it if somebody feels differently.
addaleax
approved these changes
Jun 1, 2019
Trott
approved these changes
Jun 1, 2019
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green. (I think I'd prefer that we throw an error with a code property, but that can always be changed later.)
This comment has been minimized.
This comment has been minimized.
d30c5e6 to
40bdd0c
Compare
Collaborator
5d63629 to
6b9d9cb
Compare
BridgeAR
reviewed
Jun 4, 2019
joyeecheung
reviewed
Jun 5, 2019
75fa512 to
59b5175
Compare
Member
Author
|
Ok, i will take a look |
Disallow the use of Object.defineProperty() to hide entries in process.env or make them immutable.
himself65
commented
Jan 12, 2022
ljharb
reviewed
Jan 12, 2022
Member
Author
|
hope the test will pass |
Member
Author
Download action repository 'actions/checkout@v2' (SHA:ec3a7ce113134d7a93b817d10a8272cb61118579)
Warning: Failed to download action 'https://v-api-github-com.286600.xyz/repos/actions/checkout/tarball/ec3a7ce113134d7a93b817d10a8272cb61118579'. Error: Response status code does not indicate success: 503 (Service Unavailable).
Warning: Back off 25.2 seconds before retry.
Warning: Failed to download action 'https://v-api-github-com.286600.xyz/repos/actions/checkout/tarball/ec3a7ce113134d7a93b817d10a8272cb61118579'. Error: Response status code does not indicate success: 503 (Service Unavailable).
Warning: Back off 12.773 seconds before retry.
Error: Response status code does not indicate success: 503 (Service Unavailable). |
Member
Author
|
why all ci crash and only happen in my pr? |
Member
Author
https://v-www-githubstatus-com.286600.xyz/incidents/cypv026dr23w |
Member
Author
|
@ljharb could u please take a look? thanks |
Member
|
LGTM! |
aduh95
reviewed
Jan 14, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Jan 14, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jan 15, 2022
Collaborator
Collaborator
|
Landed in e6a7300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to fix #27990
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes