Skip to content

deps: update V8 to 10.8#45230

Closed
targos wants to merge 11 commits intonodejs:mainfrom
targos:v8-108
Closed

deps: update V8 to 10.8#45230
targos wants to merge 11 commits intonodejs:mainfrom
targos:v8-108

Conversation

@targos
Copy link
Member

@targos targos commented Oct 29, 2022 •
edited
Loading

Stable Release:
Tue, Nov 29, 2022

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2022

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2022
@targos targos added dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
This was referenced Oct 30, 2022
Open
Open
@targos
Copy link
Member Author

targos commented Oct 31, 2022

There's also a failure with test-trace-gc-flag

12:10:45 not ok 1 v8-updates/test-trace-gc-flag
12:10:45   ---
12:10:45   duration_ms: 0.348
12:10:45   severity: fail
12:10:45   exitcode: 1
12:10:45   stack: |-
12:10:45     node:assert:1027
12:10:45         throw err;
12:10:45         ^
12:10:45     
12:10:45     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /\bMark-sweep\b/. Input:
12:10:45     
12:10:45     '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested'
12:10:45     
12:10:45         at /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:30:12
12:10:45         at Array.forEach (<anonymous>)
12:10:45         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:29:9)
12:10:45         at Module._compile (node:internal/modules/cjs/loader:1175:14)
12:10:45         at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)
12:10:45         at Module.load (node:internal/modules/cjs/loader:1038:32)
12:10:45         at Module._load (node:internal/modules/cjs/loader:879:12)
12:10:45         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)
12:10:45         at node:internal/main/run_main_module:23:47 {
12:10:45       generatedMessage: true,
12:10:45       code: 'ERR_ASSERTION',
12:10:45       actual: '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested',
12:10:45       expected: /\bMark-sweep\b/,
12:10:45       operator: 'match'
12:10:45     }
12:10:45     
12:10:45     Node.js v20.0.0-pre
12:10:45   ...

/cc @tony-go

@targos
Copy link
Member Author

targos commented Oct 31, 2022 •
edited
Loading

@nodejs/platform-windows

x86 build fails on Windows:

12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(344,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(59,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

This was referenced Nov 1, 2022
Open
Open
@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Nov 2, 2022

Hello, @targos. All failing asserts are manifestations of the same issue - MemoryChunkLayout::kMemoryChunkHeaderSize not being set to the correct value. I've found this commit in the v8 repo that fixes the problem. I've tried it locally and the build passes.

@targos
Copy link
Member Author

targos commented Nov 2, 2022

@StefanStojanovic thanks! I'll cherry-pick that commit

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47713/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2022

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4961/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2022

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4961/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2022

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4961/

This was referenced Nov 6, 2022
Open
Open
Open
@targos
Copy link
Member Author

targos commented Nov 19, 2022

It's the first time we land a V8 PR with the CQ. I hope it won't break anything with commit messages like this one:
image

This was referenced Nov 20, 2022
Open
Open
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@gengjiawen @anonrig
deps: fix V8 build issue with inline methods
45c5eb5 
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

deps: patch for v8 on windows

PR-URL: nodejs#40010
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs#40060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

deps: workaround debug link error on Windows

PR-URL: nodejs#38807
Refs: nodejs#38788
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@gengjiawen @anonrig
deps: V8: fix v8-cppgc.h for MSVC
11f4a81 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs#42375

PR-URL: nodejs#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@targos @anonrig
deps: silence irrelevant V8 warning
d3eba45 
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@targos @anonrig
deps: fix V8 build on Windows with MSVC
1e17605 
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: update V8 to 10.8.168.20
a3b9967 
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
build: reset embedder string to "-node.0"
54fd8a1 
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@gengjiawen @ruyadorno
deps: fix V8 build issue with inline methods
e929254 
PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

deps: patch for v8 on windows

PR-URL: #40010
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

deps: patch v8 for vs2019 in std17

PR-URL: #40060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

deps: workaround debug link error on Windows

PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@gengjiawen @ruyadorno
deps: V8: fix v8-cppgc.h for MSVC
9348bdd 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: #42375

PR-URL: #42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: silence irrelevant V8 warning
3cd6367 
PR-URL: #44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: fix V8 build on Windows with MSVC
1370b1a 
PR-URL: #44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: V8: cherry-pick 92a7385171bb
51eb323 
Original commit message:

    [heap] Fix 32bit msvc builds

    Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus
    forcing 8 bytes alignment for MemoryChunk.

    Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83845}

Refs: v8/v8@92a7385
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: V8: cherry-pick f1c888e7093e
e70c309 
Original commit message:

    [base] Fix SmartOS build

    That platform doesn't have `malloc_usable_size`.

    Refs: nodejs/node-v8#239
    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#84256}

Refs: v8/v8@f1c888e
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@anonrig @ruyadorno
deps: V8: cherry-pick 9df5ef70ff18
aaa4ac7 
Original commit message:

    Add an `v8::ArrayBuffer::WasDetached` method to the C++ API

    V8's C++ API does not give a way to tell whether an ArrayBuffer has
    been detached from the `v8::ArrayBuffer` class. In fact, as far as can
    be told from the C++ API without running JS code, detached
    ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
    no way to observe the difference. However, this difference can be
    observed in JS because constructing a TypedArray from a detached
    ArrayBuffer will throw.

    This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
    to give embedders access to this information without having to run JS
    code.

    Bug: v8:13159
    Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83963}

Refs: v8/v8@9df5ef7
PR-URL: #45474
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
test: adapt test-v8-stats for V8 update
72f2df2 
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@tony-go @ruyadorno
test: fix test-trace-gc-flag
076e9ee 
PR-URL: #45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Open
15 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 23, 2022
@targos @anonrig
deps: V8: cherry-pick f1c888e7093e
9bcc882 
Original commit message:

    [base] Fix SmartOS build

    That platform doesn't have `malloc_usable_size`.

    Refs: nodejs/node-v8#239
    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#84256}

Refs: v8/v8@f1c888e
PR-URL: nodejs#45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

# Conflicts:
#	common.gypi
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@targos @marco-ippolito
deps: update V8 to 10.8.168.20
05fc171 
PR-URL: nodejs#45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@targos @marco-ippolito
build: reset embedder string to "-node.0"
bd9ac28 
PR-URL: nodejs#45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@gengjiawen @marco-ippolito
deps: fix V8 build issue with inline methods
51825c1 
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

deps: patch for v8 on windows

PR-URL: nodejs#40010
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs#40060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

deps: workaround debug link error on Windows

PR-URL: nodejs#38807
Refs: nodejs#38788
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@gengjiawen @marco-ippolito
deps: V8: fix v8-cppgc.h for MSVC
3eabfce 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs#42375

PR-URL: nodejs#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@targos @marco-ippolito
deps: silence irrelevant V8 warning
c76deaf 
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@targos @marco-ippolito
deps: fix V8 build on Windows with MSVC
b450e8d 
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@targos @marco-ippolito
deps: V8: cherry-pick 92a7385171bb
2148812 
Original commit message:

    [heap] Fix 32bit msvc builds

    Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus
    forcing 8 bytes alignment for MemoryChunk.

    Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83845}

Refs: v8/v8@92a7385
PR-URL: nodejs#45230
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
@gengjiawen gengjiawen mentioned this pull request Feb 1, 2023
Closed
@AdamMajer AdamMajer mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

@targos targos

Labels

build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos @nodejs-github-bot @StefanStojanovic @tony-go @anonrig @gengjiawen