Skip to content

watch: fix some node argument not passed to watched process#52358

Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom
rluvaton:fix-watch-path-and-require
Apr 7, 2024
Merged

watch: fix some node argument not passed to watched process#52358
nodejs-github-bot merged 4 commits intonodejs:mainfrom
rluvaton:fix-watch-path-and-require

Conversation

@rluvaton
Copy link
Member

@rluvaton rluvaton commented Apr 3, 2024 •
edited
Loading

Some arguments were omitted instead of been sent to the spawned watched process

@rluvaton rluvaton requested a review from MoLow April 3, 2024 22:45
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 3, 2024
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
rluvaton
rluvaton commented Apr 3, 2024
View reviewed changes
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
@rluvaton rluvaton force-pushed the fix-watch-path-and-require branch from b57291b to 5a4e308 Compare April 3, 2024 23:07
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58086/

JakobJingleheimer
JakobJingleheimer reviewed Apr 4, 2024
View reviewed changes
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58100/

JakobJingleheimer
JakobJingleheimer approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58104/

@atlowChemi atlowChemi added the watch-mode Issues and PRs related to watch mode label Apr 5, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58159/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58164/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58175/

@rluvaton rluvaton added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit 893e2cf into nodejs:main Apr 7, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2024

Landed in 893e2cf

@rluvaton rluvaton deleted the fix-watch-path-and-require branch April 7, 2024 20:51
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
@MoLow MoLow mentioned this pull request Apr 28, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@rluvaton @marco-ippolito
watch: fix some node argument not passed to watched process
cf738ae 
PR-URL: #52358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@rluvaton @marco-ippolito
watch: fix some node argument not passed to watched process
7f3b7fd 
PR-URL: #52358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
KJyang-0114 added a commit to KJyang-0114/node that referenced this pull request Mar 8, 2026
@KJyang-0114
docs: add example for mocking functions that throw
d428341 
Add documentation explaining how to mock functions that throw errors
and validate them using assert.throws(). Includes examples showing
how mock tracks both successful calls and thrown errors.

PR-URL: nodejs#52358
Refs: nodejs#52357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@MoLow MoLow MoLow approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rluvaton @nodejs-github-bot @benjamingr @JakobJingleheimer @MoLow @atlowChemi