tools: support environment variables via comments#58186
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 11, 2025
Merged
tools: support environment variables via comments#58186nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Member
Author
|
I've already seen a bunch of regressions, changing the method signature may not have been the best decision(I'm trying to avoid reading the test file twice) |
830bb71 to
d674f42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58186 +/- ##
==========================================
+ Coverage 90.15% 90.17% +0.02%
==========================================
Files 630 629 -1
Lines 186756 186643 -113
Branches 36648 36651 +3
==========================================
- Hits 168362 168306 -56
+ Misses 11193 11133 -60
- Partials 7201 7204 +3 🚀 New features to boost your workflow:
|
d674f42 to
77e4612
Compare
jasnell
reviewed
May 7, 2025
| @@ -0,0 +1,16 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Environment Variables: A_SET_ENV_VAR=A_SET_ENV_VAR_VALUE B_SET_ENV_VAR=B_SET_ENV_VAR_VALUE | |||
Member
There was a problem hiding this comment.
Just a nit but I'd prefer the more compact: // Env: ...
Member
Author
There was a problem hiding this comment.
+1 (@joyeecheung suggested the same name)
I’ll go ahead and update the PR
jasnell
approved these changes
May 7, 2025
jasnell
approved these changes
May 7, 2025
77e4612 to
dfeec6e
Compare
marco-ippolito
approved these changes
May 9, 2025
Collaborator
Collaborator
|
Landed in 6184730 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58186 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Contributor
|
Added tests are failing when cherry-picked on v22.x-staging, it will require a manual backport if we want it there |
Contributor
|
Added tests are failing when cherry-picked on v22.x-staging, it will require a manual backport if we want it there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should address #58179 by adding support for environment variables via comments.
I've not run the entire test suite, only a subset.
A full CI run will be needed to catch any potential regressions!