Skip to content

doc: fix markdown for expectFailure values#62100

Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom
JakobJingleheimer:test_runner/doc/fix-broken-link-overflowing
Mar 4, 2026
Merged

doc: fix markdown for expectFailure values#62100
nodejs-github-bot merged 4 commits intonodejs:mainfrom
JakobJingleheimer:test_runner/doc/fix-broken-link-overflowing

Conversation

@JakobJingleheimer
Copy link
Member

@JakobJingleheimer JakobJingleheimer commented Mar 4, 2026 •
edited
Loading

Currently, about half the test API doc is broken (text outside of codeblocks below here is blank).

2026-03-04_11-35 test api doc broken link

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 4, 2026

Review requested:

  • @nodejs/test_runner

@JakobJingleheimer JakobJingleheimer added the fast-track PRs that do not need to wait for 72 hours to land. label Mar 4, 2026
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

aduh95
aduh95 reviewed Mar 4, 2026
View reviewed changes
JakobJingleheimer and others added 2 commits March 4, 2026 13:44
@JakobJingleheimer @aduh95
leverage auto-linking md macro
059bdf1 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
minimizing diff
3540fae
@aduh95
Copy link
Contributor

aduh95 commented Mar 4, 2026

Can we also fix

node/doc/api/test.md

Lines 1734 to 1737 in 3540fae

[<RegExp>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp),
[<Function>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function),
[<Object>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object), or
[<Error>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error)

@aduh95 aduh95 mentioned this pull request Mar 4, 2026
Open
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 4, 2026
@JakobJingleheimer
Copy link
Member Author

JakobJingleheimer commented Mar 4, 2026

@aduh95 thanks! I see you added the labels too (but left it author-ready). Mind if I send it to the commit queue? I think it has enough PR and fast-track approvals to go.

@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@nodejs-github-bot nodejs-github-bot merged commit 23ba205 into nodejs:main Mar 4, 2026
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 4, 2026

Landed in 23ba205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@avivkeller avivkeller Awaiting requested review from avivkeller

@pmarchini pmarchini Awaiting requested review from pmarchini

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JakobJingleheimer @nodejs-github-bot @aduh95 @cjihrig @Ethan-Arrowood @Renegade334