deps: V8: cherry-pick aa0b288f87cc#62136
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 9, 2026
Merged
Conversation
Original commit message:
PPC/S390: [wasm] Fix jump table offset when patching
... need to make sure patching of target occurs at the correct spot
based on what `EmitFarJumpSlot` emits. Also mask the branch offset in
PPC64 EmitJumpSlot to match `Assembler::b()`.
Change-Id: I5a8079d0079d8ad427034761d42c90b64d5746dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7642190
Reviewed-by: John <junyan1@ibm.com>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105646}
Refs: v8/v8@aa0b288
Collaborator
|
Review requested:
|
avivkeller
approved these changes
Mar 6, 2026
Member
|
Supersedes #62116 |
targos
approved these changes
Mar 6, 2026
Collaborator
Collaborator
Collaborator
Member
Author
|
This failed, but today's timer based build failed in the same way so it's not due to this cherry-pick. I've opened nodejs/build#4267 to track it. |
cjihrig
approved these changes
Mar 7, 2026
Contributor
|
Fast-track has been requested by @avivkeller. Please 👍 to approve. |
lpinca
approved these changes
Mar 8, 2026
|
Interested in this fix — we are actively building Node.js v22 on a Power Mac G5 (PPC64 big-endian, GCC 10.5, Mac OS X Leopard) and have hit several V8 PPC issues along the way. We also have an IBM POWER8 S824 (ppc64le) running Ubuntu 20.04 where we do LLM inference work. Happy to test this V8 cherry-pick on both big-endian (G5) and little-endian (POWER8) if that would help validate the wasm jump table fix across PPC variants. |
Collaborator
|
Landed in a0d8ea4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@aa0b288
Refs: #62116 (comment)