Skip to content

deps: update merve to 1.2.0#62149

Open
nodejs-github-bot wants to merge 4 commits intomainfrom
actions/tools-update-merve
Open

deps: update merve to 1.2.0#62149
nodejs-github-bot wants to merge 4 commits intomainfrom
actions/tools-update-merve

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of merve to 1.2.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Mar 8, 2026
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 8, 2026
@aduh95
Copy link
Contributor

aduh95 commented Mar 8, 2026

@anonrig looks like there was a breaking change

@anonrig
Copy link
Member

anonrig commented Mar 8, 2026

I will take a look

@anonrig anonrig self-assigned this Mar 8, 2026
@anonrig
Copy link
Member

anonrig commented Mar 9, 2026

cc @codebytere Shelley it seems unofficial.gn file will be deleted once this pull-request lands. We need to update update-merve.py file to avoid this. Just FYI in case you've some time (and faster than me) to fix it!

@anonrig anonrig force-pushed the actions/tools-update-merve branch from 3c78a76 to 35dc3c1 Compare March 9, 2026 13:00
@anonrig
Copy link
Member

anonrig commented Mar 9, 2026

PS: I've force pushed to remove the deleted files.

@aduh95
Copy link
Contributor

aduh95 commented Mar 9, 2026

The shared builds are failing because Node.js code is no longer compatible with Merve 1.0.0. Can we add some flag on merve that we could use to detect which syntax to use? E.g.

#ifdef MERVE_USE_DOT_NAME
#define DOT_NAME(exp) (exp.name)
#else
#define DOT_NAME(exp) (exp)
#endif
    exports_set->Add(context, CreateString(isolate, DOT_NAME(exp))).ToLocalChecked();

@aduh95 aduh95 force-pushed the actions/tools-update-merve branch from 35dc3c1 to fbd4685 Compare March 9, 2026 13:34
@aduh95
Copy link
Contributor

aduh95 commented Mar 9, 2026

Ended up using MERVE_ERROR_TODO as a proxy – not the cleanest, but it gets the job done; we should be able to remove that in a follow-up semver-major. I force-pushed to reintroduce the bot-generated commit and re-add the deleted files on a follow-up commit (which won't matter once the PR is merged, but makes it easier to review IMO)

EDIT: that being said, it looks like the non-shared build is still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants