test: var variables to const in zlib#8627
Closed
FeignMan wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Changes in test-zlib-from-string is because var->const pushed us over the max char limit per line.
Member
|
LGTM |
Member
Member
|
CI run looks green except for ARM failures that are also seen in early runs, |
Member
|
WIll land once a bit more time for comment passes unless we get some objections. |
not-an-aardvark
approved these changes
Sep 17, 2016
Member
This may or may not need to be rebased after #8512 anyway… the changes look good to me, though. |
mhdawson
pushed a commit
that referenced
this pull request
Sep 20, 2016
Changes in test-zlib-from-string is because var->const pushed us over the max char limit per line. PR-URL: #8627 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed as: 7a46554 |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Changes in test-zlib-from-string is because var->const pushed us over the max char limit per line. PR-URL: #8627 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Changed var variables to const in test-zlib-(etc):
Changes in test-zlib-from-string is because var->const
pushed us over the max char limit per line.