Fix parsing invalid intervals#843
Merged
Secrus merged 2 commits intopython-pendulum:masterfrom Dec 4, 2024
Merged
Conversation
Contributor
Author
|
@sdispater would you mind reviewing this PR? |
CodSpeed Performance ReportMerging #843 will not alter performanceComparing Summary
|
Secrus
reviewed
Sep 22, 2024
|
If I could suggest something, it would be just using Similarly to how you would probably prefer reading |
Contributor
Author
|
@bswck You are right. Suggestion applied. |
johnslavik
approved these changes
Sep 24, 2024
Contributor
Author
|
@Secrus would you mind reviewing this PR? |
Secrus
approved these changes
Nov 11, 2024
Contributor
Author
|
Thanks for the review. What is required to get this PR merged? |
Collaborator
|
@wiget please rebase your branch with master so the pipelines run. Right now it looks like GH has some issues here. |
Parsing string with slash at the start or the end raised IndexError instead of ParseError.
Contributor
Author
|
All checks passed. Would you mind merging this PR, @Secrus ? |
|
Is there a release planned for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a string with a slash at the start or the end raised IndexError instead of ParseError.
Pull Request Check List