gh-141376: Fix exported symbols#141377
Merged
encukou merged 2 commits intopython:mainfrom Nov 11, 2025
Merged
Conversation
* _io module: add "_Py_" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec. * typevarobject.c: add "static" to "spec" and "slots" variables. * import.c: add "static" to "pkgcontext" variable.
Member
Author
|
With this patch: diff --git a/Tools/build/smelly.py b/Tools/build/smelly.py
index 9a360412a73..0b694392583 100755
--- a/Tools/build/smelly.py
+++ b/Tools/build/smelly.py
@@ -37,7 +37,7 @@ def is_local_symbol_type(symtype):
# Ignore the initialized data section (d and D) and the BSS data
# section. For example, ignore "__bss_start (type: B)"
# and "_edata (type: D)".
- if symtype in "bBdD":
+ if symtype in "bB":
return True
return False
|
JelleZijlstra
approved these changes
Nov 10, 2025
cmaloney
approved these changes
Nov 10, 2025
Contributor
cmaloney
left a comment
There was a problem hiding this comment.
Most modules don't need the extern PyType_Spec pieces that the _io module currently uses; 👍 for this change and I added to my I/O rework notes that it would be nice to reduce the need for these.
gpshead
approved these changes
Nov 11, 2025
|
Member
|
(The noGIL failure is a known issue, #120158.) |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
* pythongh-141376: Fix exported symbols * _io module: add "_Py_" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec. * typevarobject.c: add "static" to "spec" and "slots" variables. * import.c: add "static" to "pkgcontext" variable. * No longer export textiowrapper_slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyprefix #141376