Skip to content

gh-141510: support frozendict's in the C decimal module #145165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 1 commit into from
Feb 26, 2026
Merged

gh-141510: support frozendict's in the C decimal module #145165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3963,15 +3963,21 @@ def test_flag_comparisons(self):
d.update(c.flags)
self.assertEqual(d, c.flags)
self.assertEqual(c.flags, d)
self.assertEqual(frozendict(d), c.flags)
self.assertEqual(c.flags, frozendict(d))

d[Inexact] = True
self.assertNotEqual(d, c.flags)
self.assertNotEqual(c.flags, d)
self.assertNotEqual(frozendict(d), c.flags)
self.assertNotEqual(c.flags, frozendict(d))

# Invalid SignalDict
d = {Inexact:False}
self.assertNotEqual(d, c.flags)
self.assertNotEqual(c.flags, d)
self.assertNotEqual(frozendict(d), c.flags)
self.assertNotEqual(c.flags, frozendict(d))

d = ["xyz"]
self.assertNotEqual(d, c.flags)
Expand Down
4 changes: 2 additions & 2 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ dict_as_flags(decimal_state *state, PyObject *val)
uint32_t flags = 0;
int x;

if (!PyDict_Check(val)) {
if (!PyAnyDict_Check(val)) {
PyErr_SetString(PyExc_TypeError,
"argument must be a signal dict");
return DEC_INVALID_SIGNALS;
Expand Down Expand Up @@ -802,7 +802,7 @@ signaldict_richcompare(PyObject *v, PyObject *w, int op)
if (PyDecSignalDict_Check(state, w)) {
res = (SdFlags(v)==SdFlags(w)) ^ (op==Py_NE) ? Py_True : Py_False;
}
else if (PyDict_Check(w)) {
else if (PyAnyDict_Check(w)) {
uint32_t flags = dict_as_flags(state, w);
if (flags & DEC_ERRORS) {
if (flags & DEC_INVALID_SIGNALS) {
Expand Down
Loading