Skip to content

gh-144991: Use runtime JIT threshold in _testinternalcapi #145496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 4 commits into from
Mar 5, 2026
+6 −3
Merged

gh-144991: Use runtime JIT threshold in _testinternalcapi #145496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c296a2
gh-144991: Use runtime JIT threshold in _testinternalcapi
corona10 Mar 4, 2026
9215b43
Address code review
corona10 Mar 4, 2026
1065273
Update Modules/_testinternalcapi.c
corona10 Mar 4, 2026
3b855ee
Address code review
corona10 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/internal/pycore_interp_structs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ struct _py_func_state {

/* For now we hard-code this to a value for which we are confident
all the static builtin types will fit (for all builds). */
#define _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES 201
#define _Py_MAX_MANAGED_STATIC_BUILTIN_TYPES 202
Copy link
Member

@Fidget-Spinner Fidget-Spinner Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Member

@vstinner vstinner Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because a new static type was added recently, and JIT tests crash or fail with an assertion error without this change: #145496 (comment)

#define _Py_MAX_MANAGED_STATIC_EXT_TYPES 10
#define _Py_MAX_MANAGED_STATIC_TYPES \
(_Py_MAX_MANAGED_STATIC_BUILTIN_TYPES + _Py_MAX_MANAGED_STATIC_EXT_TYPES)
Expand Down
7 changes: 5 additions & 2 deletions Modules/_testinternalcapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2966,6 +2966,8 @@ static PyMethodDef module_functions[] = {
static int
module_exec(PyObject *module)
{
PyInterpreterState *interp = PyInterpreterState_Get();

if (_PyTestInternalCapi_Init_Lock(module) < 0) {
return 1;
}
Expand Down Expand Up @@ -3007,9 +3009,10 @@ module_exec(PyObject *module)
return 1;
}

// + 1 more due to one loop spent on tracing.
unsigned long threshold = interp->opt_config.jump_backward_initial_value + 2;
if (PyModule_Add(module, "TIER2_THRESHOLD",
// + 1 more due to one loop spent on tracing.
PyLong_FromLong(JUMP_BACKWARD_INITIAL_VALUE + 2)) < 0) {
PyLong_FromUnsignedLong(threshold)) < 0) {
return 1;
}

Expand Down
Loading