bpo-32346: speed up slot lookup during class creation#4902
Closed
pitrou wants to merge 9 commits intopython:masterfrom
Closed
bpo-32346: speed up slot lookup during class creation#4902pitrou wants to merge 9 commits intopython:masterfrom
pitrou wants to merge 9 commits intopython:masterfrom
Conversation
Instead of looking up every possible slot in every class along the MRO (generating possibly hundreds of dict lookups), cache the known descriptors of each type so that finding them again is simply a matter of walking a tuple.
Member
Author
|
@serhiy-storchaka, is there any chance you might give this a look soon? |
Member
|
Sure. I was busy due to working on the compiler, but the hardest work is already done, and I have now more free time. |
6298f68 to
694e1b0
Compare
Member
Author
|
Rejected because of memory and GC overhead: see https://bugs.python.org/issue32346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of looking up every possible slot in every class along the MRO (generating possibly hundreds of dict lookups), cache the known descriptors of each type so that finding them again is simply a matter of walking a tuple.
https://bugs.python.org/issue32346