gh-96254: Add new wasm build target and support a pkg_config_path#96252
Closed
rchiodo wants to merge 3 commits intopython:mainfrom
Closed
gh-96254: Add new wasm build target and support a pkg_config_path#96252rchiodo wants to merge 3 commits intopython:mainfrom
rchiodo wants to merge 3 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Author
|
/cc @brettcannon @tiran |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to: https://discuss.python.org/t/get-ctypes-working-in-emscripten-build/18466, this adds the following:
The PKG_CONFIG_PATH addition seems kinda hacky though. @tiran had suggested another workaround to get this to work. I thought I'd put this out there to see what people thought. It is more explicit than having to find where emscripten has its sysroot though.