Skip to content

Use sphinx-lint in make check.#866

Merged
ezio-melotti merged 4 commits intopython:mainfrom
ezio-melotti:update-make-check
May 16, 2022
Merged

Use sphinx-lint in make check.#866
ezio-melotti merged 4 commits intopython:mainfrom
ezio-melotti:update-make-check

Conversation

@ezio-melotti
Copy link
Member

This is a follow-up of python/cpython#92290 which updates make check to use sphinx-lint.

@ezio-melotti ezio-melotti added the type-feature Additions; New content or section needed label May 15, 2022
@ezio-melotti ezio-melotti self-assigned this May 15, 2022
@ezio-melotti ezio-melotti requested review from hugovk and zware May 15, 2022 18:49
@ezio-melotti ezio-melotti mentioned this pull request May 15, 2022
5 tasks
@ezio-melotti ezio-melotti requested a review from a team May 16, 2022 14:14
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it looks good, though I haven't tested it and am not sure what it's doing other than installing a package. But the batch file syntax seems okay

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@ezio-melotti ezio-melotti merged commit 7b86c20 into python:main May 16, 2022
@ezio-melotti ezio-melotti deleted the update-make-check branch May 16, 2022 21:43
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Use sphinx-lint in `make check`.

* Fix missing newlines at the end of files.

* Add `venv` as a dependency for the `check` target.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* Specify `sphinx-lint` version in `make.bat`.

Co-authored-by: Steve Dower <steve.dower@microsoft.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature Additions; New content or section needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants