Conversation
…aults to not assume that type checkers will infer a class object as having a `type[]` type
JelleZijlstra
approved these changes
Mar 4, 2026
carljm
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many tests in
conformance/tests/generics_defaults.pyandconformance/tests/generics_defaults_referential.pycurrently assume that a type checker will infer a class object as having atype[]type. Buttype[int]doesn't mean "the class objectint", it means "the class objectint, or any subclass thereof", which is insufficiently precise in many cases for ty's purposes. ty therefore infers "class-literal types" for class objects rather than atype[]type.If a type assertion fails due to the actual inferred type being a more precise, unspellable subtype of the asserted type, ty will emit
assert-type-unspellable-subtypeinstead oftype-assertion-failure(ty's inferred type of<class 'int'>is an unspellable subtype oftype[int]). We may switch this error code off when we add ty's conformance results soon. But several of these tests are assertions involving non-fully-static types, so it is not true that the actual type is even a subtype of the asserted type in these cases (non-fully-static types do not participate in subtyping).This PR reworks these tests to make the assertions more ty-friendly in these respects, while keeping the assertions just as precise as they were before.