Skip to content

Upgrade grpc 1640#61459

Draft
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1640
Draft

Upgrade grpc 1640#61459
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1640

Conversation

@rueian
Copy link
Contributor

@rueian rueian commented Mar 3, 2026

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

@codope
Revert "[core] upgrade grpc to 1.58.0 to fix getenv races (ray-projec…
f59d468 
…t#61195)"

This reverts commit d85ed28.

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 3, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades gRPC to v1.64.0 and its dependency boringssl. The version update itself is straightforward, but it introduces a critical risk related to the custom patches applied to gRPC. I have added a comment highlighting the need to verify and potentially update these patches to ensure they are compatible with the new gRPC version, as this could otherwise lead to build failures or runtime issues.

bazel/ray_deps_setup.bzl
Comment on lines +280 to +281
url = "https://github.com/grpc/grpc/archive/refs/tags/v1.64.0.tar.gz",
sha256 = "d5509e40fb24f6390deeef8a88668124f4ec77d2ebb3b1a957b235a2f08b70c0",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

With this gRPC upgrade to v1.64.0, the existing patches may no longer be compatible. Please verify that the following patches apply correctly and update them if necessary:

  • @io_ray//thirdparty/patches:grpc-cython-copts.patch
  • @io_ray//thirdparty/patches:grpc-zlib-fdopen.patch
  • @io_ray//thirdparty/patches:grpc-configurable-thread-count.patch

An incompatibility could lead to build failures or subtle runtime bugs, especially since some patches modify C++ source code.

@rueian
Upgrade grpc to v1.64.0.
0164397 
Align grpc companion dependencies for this release and keep Ray Bazel dependency fetch/load working on this branch.

Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
@rueian rueian force-pushed the upgrade-grpc-1640 branch from 7fab653 to 0164397 Compare March 3, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

2 participants

@rueian @codope