Skip to content

Upgrade grpc 1600#61461

Draft
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1600
Draft

Upgrade grpc 1600#61461
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1600

Conversation

@rueian
Copy link
Contributor

@rueian rueian commented Mar 3, 2026

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

@codope
Revert "[core] upgrade grpc to 1.58.0 to fix getenv races (ray-projec…
f59d468 
…t#61195)"

This reverts commit d85ed28.

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 3, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades gRPC from v1.58.0 to v1.60.0. A security review found no vulnerabilities. However, the existing patches applied to gRPC appear to be incompatible with the new version. At least two of the three patches will fail to apply due to significant changes in the upstream gRPC code, which will likely cause the build to fail and needs to be addressed.

bazel/ray_deps_setup.bzl
Comment on lines +280 to +281
url = "https://github.com/grpc/grpc/archive/refs/tags/v1.60.0.tar.gz",
sha256 = "437068b8b777d3b339da94d3498f1dc20642ac9bfa76db43abdd522186b1542b",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While the gRPC version and SHA256 are correctly updated, the associated patches have not been validated against the new version. My analysis indicates that at least two patches are no longer compatible and will cause build failures:

  • grpc-zlib-fdopen.patch (line 284): The zlib dependency in grpc's bazel/grpc_deps.bzl has changed, making this patch obsolete.
  • grpc-configurable-thread-count.patch (line 285): The target file src/core/lib/gpr/linux/cpu.cc has been significantly refactored.

Please update or remove these patches to be compatible with gRPC v1.60.0.

@rueian
Upgrade grpc to v1.60.0.
6e2e62d 
Align grpc companion dependencies for this release and keep Ray Bazel dependency fetch/load working on this branch.

Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
@rueian rueian force-pushed the upgrade-grpc-1600 branch from 2e18e2a to 6e2e62d Compare March 3, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

2 participants

@rueian @codope