[WIP][Core] Add labels as ref IDs to the actor definition OneEvent to be able to link actor and Ray Data operator#61469
Draft
coqian wants to merge 1 commit intoray-project:masterfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds labels to the actor definition event, which can be used for correlation with other events. The changes involve updating protobuf definitions to include labels in ActorTableData and ref_ids in ActorDefinitionEvent, and then populating these fields. The implementation is mostly correct, but there's a minor point of inconsistency in how a map is populated in gcs_actor.h which could be improved for consistency and clarity.
…ble to link actor and Ray Data operator Signed-off-by: cong.qian <cong.qian@anyscale.com>
5d25cd7 to
67c97c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.