Use .get() for discriminator access in generated union encoders#176
Merged
darshkpatel merged 1 commit intomainfrom Mar 5, 2026
Merged
Use .get() for discriminator access in generated union encoders#176darshkpatel merged 1 commit intomainfrom
darshkpatel merged 1 commit intomainfrom
Conversation
The discriminator field may be NotRequired in the TypedDict, so direct key access (x["key"]) triggers pyright's reportTypedDictNotRequiredAccess. Using .get() is safe because a missing key returns None, which won't match any discriminator value and falls through to the next branch.
jackyzha0
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #175. The discriminator field in a discriminated union may be
NotRequiredin the TypedDict. Direct key access (x["shapeType"]) triggers pyright'sreportTypedDictNotRequiredAccesserror.This broke the pid2 codegen CI when the scribe schema added discriminated union variants where the discriminator field is optional.
What changed
Use
x.get("key")instead ofx["key"]for discriminator checks in the generated ternary chain. This is safe because a missing key returnsNone, which won't match any discriminator value and falls through to the next branch.Test plan
test_unknown_enum~ written by Zerg 👾