Stack and concatenate#844
Merged
bluss merged 7 commits intorust-ndarray:masterfrom Oct 23, 2020
andrei-papou:ap/stack-and-concatenate
Merged
Stack and concatenate#844bluss merged 7 commits intorust-ndarray:masterfrom andrei-papou:ap/stack-and-concatenate
bluss merged 7 commits intorust-ndarray:masterfrom
andrei-papou:ap/stack-and-concatenate
Conversation
…ck`, `stack` -> `stack_new_axis`
Closed
Member
|
Thanks! Finally merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #667
Continuation of #735 with the commit history being cleaned up.
Changes:
concatenateproxy function tostackfunction,concatenate!proxy macro tostack!macrostackfunction andstack!macro since0.13.2stack_new_axisfunction andstack_new_axis!macro to mimic the behavior ofnp.stackfunction from numpyIn 0.14.0 we should probably rename
stack_new_axistostackand drop oldstackfunction, same about macro.concatenate
stack_new_axis