This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Merged
Conversation
Names are not totally reliable to find the jobs anymore when we truncate them.
This lets us add a `-` and 5 random chars to ensure unquire names.
Getting individual jobs is harder now, as the name has a random string at the end. Listing all jobs is more helpfull anyway, as it also lists jobs for hooks
jorgestiga
approved these changes
Jun 22, 2020
rfelber
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
This includes some notable changes as the name of the jobs is no not deterministic anymore.
Before this PR change: a scan called:
nmap-localhostWould always create the same jobs:
scan-nmap-localhostparse-nmap-localhostBut the problem is this could result in to long job names (>= 63 chars).
After this PR these Jobs will always include a random element at the end and never be longer than 63 chars, like:
scan-nmap-localhost-8j7fmparse-nmap-localhost-54z2m