Refactor usesSegments method into usesMatcher method#324
Merged
EmilianoSanchez merged 1 commit intoSDKS-8407_baselinefrom Jul 16, 2024
Merged
Refactor usesSegments method into usesMatcher method#324EmilianoSanchez merged 1 commit intoSDKS-8407_baselinefrom
usesSegments method into usesMatcher method#324EmilianoSanchez merged 1 commit intoSDKS-8407_baselinefrom
Conversation
gthea
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
ISplitsCacheBase::usesSegment(): booleanmethod into a more generic versionISplitsCacheBase::usesMatcher(matcherType: string): boolean, to use for both IN_SEGMENT and IN_LARGE_SEGMENT matchers.How do we test the changes introduced in this PR?
Extra Notes