Support Predicate<RequestPath>> in path API version resolver#36398
Open
siom79 wants to merge 9 commits intospring-projects:mainfrom
Open
Support Predicate<RequestPath>> in path API version resolver#36398siom79 wants to merge 9 commits intospring-projects:mainfrom
Predicate<RequestPath>> in path API version resolver#36398siom79 wants to merge 9 commits intospring-projects:mainfrom
Conversation
…th) in ApiVersionConfigurer to exclude certain paths Signed-off-by: Martin Mois <martin.mois@gmail.com> Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
rstoyanchev
requested changes
Mar 2, 2026
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
Overall looks good, but I think the predicate should be to confirm if the path has a version rather based on exclusion, i.e. true if it is a path with a version, and false otherwise.
That would reflect more specifically the purpose of levelling up to other resolvers in being able to detect presence vs absence.
If we ever decide to overlay that with exclusions by path at the top level across resolvers the two would be more contrasted.
Predicate<RequestPath>> in path API version resolver
rstoyanchev
reviewed
Mar 2, 2026
Contributor
|
One more comment, if you want to improve the PR, the same change is needed on the Spring MVC side too. |
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Martin Mois <martin.mois@gmail.com>
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
…stPath> includePath) in spring-webmvc Signed-off-by: Martin Mois <martin.mois@gmail.com>
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Martin Mois <martin.mois@gmail.com>
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Martin Mois <martin.mois@gmail.com>
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Martin Mois <martin.mois@gmail.com>
siom79
added a commit
to siom79/spring-framework
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
…stPath> includePath) in spring-webmvc Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
Signed-off-by: Martin Mois <martin.mois@gmail.com>
rstoyanchev
approved these changes
Mar 3, 2026
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
Thanks for the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #36395 this pull requests provides the new method usePathSegment(int index, Predicate excludePath)
in ApiVersionConfigurerto exclude certain paths