This repository was archived by the owner on Sep 8, 2021. It is now read-only.
[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions#39
Merged
txase merged 2 commits intostackery:masterfrom May 31, 2019
titomiguelcosta:master
Merged
[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions#39txase merged 2 commits intostackery:masterfrom titomiguelcosta:master
txase merged 2 commits intostackery:masterfrom
titomiguelcosta:master
Conversation
Contributor
Author
|
To test my PR, just change to my branch and run |
txase
suggested changes
May 31, 2019
Member
txase
left a comment
There was a problem hiding this comment.
This looks good to me! Can you also update the readme with the additional extensions this provides in the runtime layer?
🙏
Contributor
Author
@txase sure thing, done. copied the output of the command and put on the README sorted alphabetically |
txase
approved these changes
May 31, 2019
Member
|
Thanks! I’ll look to update the layer in AWS early next week! |
|
xmlreader still missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, fixes issue #38
In the end, it was a small fix. When building the php73.zip there were errors in installing remi repo, and it all came down to the order we installed epel and remi, reverting those instructions fixed the problem.
In term of adding the missing extensions required by Symfony 4, I only had to add php-xml and php-process to the list of php packages to be installed.
I tested and deployed the generated layer. phpinfo can be seen here (this page will be deleted once we merge this PR).
Side note: I did not explore, but I wonder why do we need to install httpd as part of building the image?! In my case, I'm using API Gateway to handle the requests and fire the lambda. I might be missing something but I do not think we need apache.