Show estimated cost for subscription users with opt-out setting#464
Open
Priyans-hu wants to merge 1 commit intosteipete:mainfrom
Open
Show estimated cost for subscription users with opt-out setting#464Priyans-hu wants to merge 1 commit intosteipete:mainfrom
Priyans-hu wants to merge 1 commit intosteipete:mainfrom
Conversation
|
I'd very much request that this is not removed. |
Instead of hiding dollar amounts for subscription users, keep them visible with a hint that these are API-equivalent estimates. Adds a "Include cost for subscription plans" toggle in General preferences (under Usage) so users can opt out if they find it confusing. When enabled, subscription users see their cost lines as before plus a footnote: "Estimated at API rates — not your actual spend". When disabled, only token counts are shown. Closes steipete#92
737c75b to
714f5ad
Compare
Contributor
Author
|
Good point — updated the approach. Now keeps the cost visible with a hint ("Estimated at API rates — not your actual spend") and adds a toggle under General → Usage so users can opt out if they want. API users are unaffected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #92 — subscription users (Pro, Max, Team) were seeing raw API dollar amounts that don't reflect their actual spend.
Instead of hiding the cost entirely (which loses the budgeting value @RemoteCTO mentioned), this keeps costs visible with a clear disclaimer and lets users toggle it off.
What changed:
showEstimatedCostForSubscriptionssetting (default: on)Files touched:
SettingsStoreState.swift/SettingsStore.swift/SettingsStore+Defaults.swift— new settingMenuCardView.swift— pass setting through Input, conditionally show cost + hintStatusItemController+Menu.swift/PreferencesProvidersPane.swift— wire setting to both Input call sitesPreferencesGeneralPane.swift— toggle UICloses #92