INCLUDE_UNTRACKED option not working for diffs

[kmctown]

libgit2 provides diff_options flags to git_diff_tree_to_workdir_with_index such as including untracked (unstaged) files in a diff. I've added that here using the normalizeOptions pattern and it does not seem to be working. I think being able to pass these flags in increases nodegit's usefulness to a wider range of use cases, so I'd like to get this working here.

[tbranyen]

Hrm why did you close/delete this?

[kmctown]

Was an accident. Too many commits were on the PR and wanted to clean them up.

[johnhaley81]

You can just force push to clean them up.

[kmctown]

Will do 👍

[johnhaley81]

Usually what we've been doing is keeping open a [WIP] PR and would just push to it so people could track what we're doing. When we're ready to actually merge it back in we'd clean up the commits, force push it to the branch and then remove the [WIP] tag.

We're not always diligent about removing the tag though.

[johnhaley81]

Should we re-open this then?

[kmctown]

Apologize for the mess -- it's set up now as originally intended. On to solving the problem!

[johnhaley81]

This should be rebased on top of #374 after it's merged. It's going to need the code from that for the callbacks to work properly.

[kmctown]

Sounds like a plan 👍

[johnhaley81]

#374 is merged. I rebased untracked on top of master.

[orderedlist]

The tests on Appveyor that are failing are the same ones that we're trying to fix, and are unrelated to this PR. I say we

[johnhaley81]

Currently the tests fail in AppVeyor on master as well. Fixing those are out of scope of this PR and will be handled in a different one ASAP. That being said I don't think that's a valid reason for halting this right now since it's most likely a problem with the tests themselves and not the library.

Going to go ahead and merge this.