Merged
Conversation
Unlike structs, classes don't store the callbacks on the object. Instead they are passed into the function and have to be hanled differently. Currently this is breaking the combyne templating and after that is fixed this should build. But this is what we need to get going for status and diff to start working.
Collaborator
|
@orderedlist So the latest commit that I pushed is what I think we're going to need to implement to get that callback stuff working. Currently something is breaking the combyne templating when it's loading the partial templates. I saw this in |
Collaborator
|
@orderedlist ok this is building now. You should be able to start working with the callbacks now hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statusssessssssssss